Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore failing unit tests in network management #10543

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore: ignore failing unit tests in network management #10543

merged 1 commit into from
Mar 14, 2024

Conversation

JoeWang1127
Copy link
Contributor

In this PR:

  • Ignore failing unit tests in network management.

This is a temporary fix of googleapis/sdk-platform-java#1839.

Confirm the change can generate @Ignore annotation to failing tests:

pip install library_generation
python library_generation/generate_repo.py generate --generation-config-yaml="$(pwd)"/generation_config.yaml --target-library-api-shortname=networkmanagement

For simplicity, I copied library_generation directory in sdk-platform-java to my local google-cloud-java repo.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 14, 2024 15:48
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 14, 2024 15:48
@JoeWang1127 JoeWang1127 mentioned this pull request Mar 14, 2024
Open
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) March 14, 2024 15:55
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@JoeWang1127 JoeWang1127 merged commit 598d25d into main Mar 14, 2024
29 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/ignore-ut-network-management branch March 14, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @suztomo @blakeli0